Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore for release notes table script: fix two matching issues for repo name and PR number #13793

Merged
merged 1 commit into from Jul 3, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jun 6, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added the translation/no-need No need to translate this PR. label Jun 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2023
@qiancai qiancai requested a review from ran-huang June 6, 2023 07:39
@qiancai qiancai changed the title chore: fix two bugs in release_notes_update_pr_author_info_add_dup.py chore for release notes table script: fix two matching issues for repo name and PR number Jun 9, 2023
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 05:54:11.985135068 +0000 UTC m=+64066.233056891: ☑️ agreed by ran-huang.

@qiancai qiancai added the lgtm label Jul 3, 2023
@qiancai qiancai merged commit b757eb5 into pingcap:master Jul 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants