Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiFlash: update the JSON push-down instruction #13875

Merged
merged 4 commits into from Jul 10, 2023
Merged

TiFlash: update the JSON push-down instruction #13875

merged 4 commits into from Jul 10, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jun 14, 2023 •
edited

What is changed, added or deleted? (Required)

TiDB has supported pushing some JSON functions to TiFlash since v6.5. This PR fixes the non-support info in the doc.

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2023
@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 14, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented Jul 7, 2023

Removed the needs-cherry-pick-release-6.6 label because the v6.6 docs have been archived at https://docs-archive.pingcap.com/tidb/v6.6 and will no longer receive new updates.

@lilin90 lilin90 self-requested a review July 10, 2023 08:12
lilin90
lilin90 reviewed Jul 10, 2023
View reviewed changes
data-type-json.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 08:38:00.111892583 +0000 UTC m=+321171.882231299: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Jul 10, 2023
@lilin90
Copy link
Member

lilin90 commented Jul 10, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit 74b13a7 into pingcap:master Jul 10, 2023
8 of 9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 10, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14172.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #14173.

This was referenced Jul 10, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14174.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 10, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14175.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
TiFlash: update the JSON push-down instruction (#13875) (#14174)
15aa6f4
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
TiFlash: update the JSON push-down instruction (#13875) (#14175)
721f953
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
TiFlash: update the JSON push-down instruction (#13875) (#14172)
bcb9aa5
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
TiFlash: update the JSON push-down instruction (#13875) (#14173)
3eb91b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

Assignees
No one assigned
Labels
approved area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. lgtm needs-1-more-lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qiancai @lilin90 @ti-chi-bot