Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-lightning: add 50TB data import best practices doc #13921

Merged
merged 27 commits into from Jun 29, 2023
Merged

tidb-lightning: add 50TB data import best practices doc #13921

merged 27 commits into from Jun 29, 2023

Conversation

niubell
Copy link
Contributor

@niubell niubell commented Jun 16, 2023 •
edited by hfxsd

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 16, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 16, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2023
@hfxsd hfxsd self-assigned this Jun 16, 2023
@hfxsd hfxsd marked this pull request as draft June 16, 2023 09:41
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2023
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/best-practices TiDB best practices area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. labels Jun 16, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 16, 2023
@hfxsd hfxsd added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jun 16, 2023
@hfxsd hfxsd requested a review from Frank945946 June 18, 2023 11:26
@hfxsd hfxsd marked this pull request as ready for review June 18, 2023 11:26
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2023
@hfxsd hfxsd self-requested a review June 20, 2023 10:08
@hfxsd hfxsd requested a review from lilin90 June 21, 2023 00:54
@hfxsd
Copy link
Collaborator

hfxsd commented Jun 21, 2023

/review 1. Evaluate the title, description, and diff of the PR. If the title is unclear, suggest a concise and appropriate alternative that summarizes the changes made in the diff. 2. Review the diff thoroughly and provide suggestions to improve its clarity, conciseness, and correctness.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2023

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lilin90
lilin90 reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-27 10:01:16.715209181 +0000 UTC m=+701842.116459615: ☑️ agreed by hfxsd.
  • 2023-06-28 09:52:06.289147526 +0000 UTC m=+787691.690397960: ☑️ agreed by lilin90.

@hfxsd hfxsd added needs-cherry-pick-release-7.2 and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 29, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Jun 29, 2023

/verify

@hfxsd
Copy link
Collaborator

hfxsd commented Jun 29, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit 5347157 into pingcap:master Jun 29, 2023
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14037.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 29, 2023
@ti-chi-bot
tidb-lightning: add 50TB data import best practices doc (#13921) (#14037
cd4c61f 
)
@hfxsd hfxsd added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jul 5, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14124.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
tidb-lightning: add 50TB data import best practices doc (#13921) (#14124
9a5382e 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@hfxsd hfxsd hfxsd approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/best-practices TiDB best practices area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@niubell @CLAassistant @hfxsd @ti-chi-bot @lilin90 @Frank945946