Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd: bugfix for the description on Slow Score. #13974

Merged
merged 2 commits into from Jul 10, 2023
Merged

pd: bugfix for the description on Slow Score. #13974

merged 2 commits into from Jul 10, 2023

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Jun 25, 2023 •
edited by qiancai

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@LykxSassinator
pd: bugfix for the description on Slow Score.
c57ff0f 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator LykxSassinator mentioned this pull request Jun 25, 2023
Merged
17 tasks
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2023
@LykxSassinator
Copy link
Contributor Author

/cc @qiancai PTAL

@ti-chi-bot ti-chi-bot bot requested a review from qiancai June 26, 2023 02:52
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

@LykxSassinator: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @qiancai PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 26, 2023
@qiancai qiancai added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jun 26, 2023
@LykxSassinator @qiancai
Update best-practices/pd-scheduling-best-practices.md
500382a 
Co-authored-by: Grace Cai <qqzczy@126.com>
qiancai
qiancai approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This was referenced Jun 30, 2023
Merged
Closed
Merged
Merged
Merged
@qiancai
Copy link
Collaborator

qiancai commented Jul 7, 2023

Removed the needs-cherry-pick-release-6.6 label because the v6.6 docs have been archived at https://docs-archive.pingcap.com/tidb/v6.6 and will no longer receive new updates.

@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed needs-cherry-pick-release-6.6 labels Jul 7, 2023
@lilin90 lilin90 added needs-cherry-pick-release-7.2 and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jul 10, 2023
lilin90
lilin90 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-30 10:57:44.278348865 +0000 UTC m=+83147.652926710: ☑️ agreed by qiancai.
  • 2023-07-10 08:15:42.824080232 +0000 UTC m=+319834.594418945: ☑️ agreed by lilin90.

@lilin90
Copy link
Member

lilin90 commented Jul 10, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6598f24 into pingcap:master Jul 10, 2023
8 of 9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 10, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14168.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 10, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14169.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #14170.

This was referenced Jul 10, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14171.

@LykxSassinator LykxSassinator deleted the bugfix-slow-score branch July 10, 2023 08:33
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
pd: bugfix for the description on Slow Score. (#13974) (#14169)
cd40630
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
pd: bugfix for the description on Slow Score. (#13974) (#14168)
eda0228
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
pd: bugfix for the description on Slow Score. (#13974) (#14170)
1b8b828
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
pd: bugfix for the description on Slow Score. (#13974) (#14171)
623794c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LykxSassinator @qiancai @lilin90 @ti-chi-bot