Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add switch for check constraint #13998

Merged
merged 6 commits into from Jun 28, 2023
Merged

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Jun 27, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 27, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2023
@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.2 labels Jun 27, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 27, 2023
@qiancai qiancai self-assigned this Jun 27, 2023
@qiancai qiancai self-requested a review June 27, 2023 11:41
constraints.md Outdated Show resolved Hide resolved
constraints.md Outdated Show resolved Hide resolved
constraints.md Outdated Show resolved Hide resolved
constraints.md Outdated Show resolved Hide resolved
system-variables.md Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

constraints.md Outdated Show resolved Hide resolved
constraints.md Outdated Show resolved Hide resolved
constraints.md Outdated Show resolved Hide resolved
constraints.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 28, 2023

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-28 01:53:53.242058474 +0000 UTC m=+758998.643308922: ☑️ agreed by qiancai.
  • 2023-06-28 04:45:19.478583659 +0000 UTC m=+769284.879834109: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator

qiancai commented Jun 28, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 79863d6 into pingcap:master Jun 28, 2023
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants