Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: RU info in explain analyze #14234

Merged
merged 10 commits into from Aug 3, 2023
Merged

resource_control: RU info in explain analyze #14234

merged 10 commits into from Aug 3, 2023

Conversation

songrijie
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

RU was included in explain analyze since v7.0.0. This information is missing in user doc.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2023
@hfxsd hfxsd self-assigned this Jul 25, 2023
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-7.0 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 25, 2023
hfxsd
hfxsd reviewed Jul 25, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jul 25, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jul 26, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from qiancai July 26, 2023 09:48
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-14 16:53:38.66313568 +0000 UTC m=+696510.433474377: ☑️ agreed by dveeden.
  • 2023-07-26 09:49:03.856413857 +0000 UTC m=+347886.450944844: ☑️ agreed by hfxsd.

@HuSharp HuSharp changed the title RU info in explain analyze resource_control: RU info in explain analyze Jul 31, 2023
HuSharp
HuSharp approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

@CabinfeverB: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ran-huang ran-huang mentioned this pull request Jul 31, 2023
Merged
17 tasks
qiancai
qiancai reviewed Jul 31, 2023
View reviewed changes
sql-statements/sql-statement-explain-analyze.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-explain-analyze.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-explain-analyze.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
@hfxsd @qiancai
Apply suggestions from code review
a62ee4b 
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd
Copy link
Collaborator

hfxsd commented Aug 3, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit c582606 into master Aug 3, 2023
10 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14417.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #14418.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14419.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 3, 2023
@ti-chi-bot
resource_control: RU info in explain analyze (#14234) (#14417)
cd916e6
ti-chi-bot bot pushed a commit that referenced this pull request Aug 3, 2023
@ti-chi-bot
resource_control: RU info in explain analyze (#14234) (#14418)
d2f56c7
ti-chi-bot bot pushed a commit that referenced this pull request Aug 3, 2023
@ti-chi-bot
resource_control: RU info in explain analyze (#14234) (#14419)
4233aab
@lilin90 lilin90 deleted the RU-in-explain-analyze branch August 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dveeden dveeden dveeden approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@hfxsd hfxsd hfxsd approved these changes

@HuSharp HuSharp HuSharp approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@songrijie @hfxsd @ti-chi-bot @dveeden @CabinfeverB @HuSharp @qiancai