Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-plan-replayer: add doc for historical stats integration into the plan replayer #14243

Merged

Conversation

time-and-fate
Copy link
Member

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2023
@ran-huang ran-huang added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jul 25, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 25, 2023
@ran-huang ran-huang self-assigned this Jul 25, 2023
@ran-huang ran-huang self-requested a review July 25, 2023 03:28
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

sql-plan-replayer.md Outdated Show resolved Hide resolved
sql-plan-replayer.md Outdated Show resolved Hide resolved
Co-authored-by: Ran <huangran.alex@gmail.com>
sql-plan-replayer.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-25 07:16:09.832533311 +0000 UTC m=+252312.427064296: ☑️ agreed by ran-huang.
  • 2023-07-26 10:54:15.980874318 +0000 UTC m=+351798.575405291: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang ran-huang added the v7.3 This PR/issue applies to TiDB v7.3. label Aug 9, 2023
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 50175c2 into pingcap:master Aug 9, 2023
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #14469.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.3 This PR/issue applies to TiDB v7.3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants