Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: add enable-diagnose-logs param #14303

Merged
merged 5 commits into from Aug 3, 2023
Merged

lightning: add enable-diagnose-logs param #14303

merged 5 commits into from Aug 3, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jul 21, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • add enable-diagnose-logs param

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 21, 2023
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2023
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2023
@hfxsd hfxsd self-assigned this Jul 21, 2023
@hfxsd hfxsd added the v7.3 This PR/issue applies to TiDB v7.3. label Jul 21, 2023
@hfxsd hfxsd requested a review from Oreoxmt July 26, 2023 08:03
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jul 28, 2023
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-26 09:50:19.372328643 +0000 UTC m=+347961.966859616: ☑️ agreed by hfxsd.
  • 2023-08-01 14:51:52.486701319 +0000 UTC m=+196996.429049850: ☑️ agreed by Oreoxmt.

@hfxsd
Copy link
Collaborator

hfxsd commented Aug 3, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit fa92084 into master Aug 3, 2023
10 checks passed
@lilin90 lilin90 deleted the diagnose-log branch August 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.3 This PR/issue applies to TiDB v7.3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants