Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add calibrate resource error and metrics description #14351

Merged
merged 6 commits into from Aug 3, 2023

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jul 26, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

As tittle

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Jul 26, 2023
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2023
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-7.2 area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jul 26, 2023

/verify

@hfxsd hfxsd requested a review from qiancai July 26, 2023 09:49
Copy link
Contributor

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep with #14132

dashboard/dashboard-resource-manager.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-calibrate-resource.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-calibrate-resource.md Outdated Show resolved Hide resolved
Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

@CabinfeverB: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM!

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

rest LGTM!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Hu# <ihusharp@gmail.com>
@hfxsd
Copy link
Collaborator Author

hfxsd commented Aug 3, 2023

/verify

dashboard/dashboard-resource-manager.md Outdated Show resolved Hide resolved
grafana-resource-control-dashboard.md Outdated Show resolved Hide resolved
grafana-resource-control-dashboard.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-calibrate-resource.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-calibrate-resource.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-calibrate-resource.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-manager.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai added the lgtm label Aug 3, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented Aug 3, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4637582 into pingcap:master Aug 3, 2023
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14420.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants