Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-variables: update docs for hint SET_VAR #15059

Merged
merged 5 commits into from Oct 31, 2023

Conversation

shawn0915
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

ref to: https://asktug.com/t/topic/1014450

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution Indicates that the PR was contributed by an external member. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Oct 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

Welcome @shawn0915!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 13, 2023

/cc @winoros

@ti-chi-bot ti-chi-bot bot requested a review from winoros October 13, 2023 07:53
@Oreoxmt Oreoxmt added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 13, 2023
fix 404 (hard link).
@hfxsd hfxsd self-assigned this Oct 25, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 25, 2023

/verify

system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review October 25, 2023 08:19
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 02:22:19.349496184 +0000 UTC m=+2401336.936606317: ☑️ agreed by hfxsd.
  • 2023-10-31 02:01:01.109416989 +0000 UTC m=+2918458.696527134: ☑️ agreed by Oreoxmt.

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 31, 2023

/approve

1 similar comment
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 31, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd, Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit 015e287 into pingcap:master Oct 31, 2023
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15223.

@shawn0915
Copy link
Contributor Author

@Oreoxmt @hfxsd @winoros @Icemap thank you all. 🙏‍

@shawn0915 shawn0915 deleted the sys-var-patch-1 branch October 31, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution Indicates that the PR was contributed by an external member. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants