Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing explain formats #15601

Merged
merged 4 commits into from Dec 21, 2023
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Dec 5, 2023

What is changed, added or deleted? (Required)

Explain formats are defined here in TiDB. However the list of formats in the documentation was a lot shorter. Note that the verbose and plan_cache formats were already listed elsewhere in the docs.

This only adds verbose and plan_cache. Maybe others like cost_trace etc. should also be added?

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2023
@lilin90 lilin90 requested review from qiancai and removed request for ran-huang and Oreoxmt December 6, 2023 06:44
@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Dec 6, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 6, 2023
@qiancai qiancai self-assigned this Dec 6, 2023
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 7, 2023

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sql-statements/sql-statement-explain.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-explain.md Outdated Show resolved Hide resolved
@qiancai qiancai added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 labels Dec 19, 2023
dveeden and others added 2 commits December 19, 2023 10:05
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 01:09:08.860456121 +0000 UTC m=+1096039.897683047: ☑️ agreed by qiancai.
  • 2023-12-21 01:39:47.922439345 +0000 UTC m=+1097878.959666273: ☑️ agreed by hfxsd.

Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qiancai
Copy link
Collaborator

qiancai commented Dec 21, 2023

/approve

Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1cb6c15 into pingcap:master Dec 21, 2023
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15825.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15826.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15827.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15828.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@qiancai qiancai added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. labels Dec 26, 2023
@qiancai qiancai removed their assignment Dec 26, 2023
@yusra1007
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository.
Development

Successfully merging this pull request may close these issues.

None yet

7 participants