Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system variable: restored an overidden description about tidb_restricted_read_only #15843

Merged
merged 1 commit into from Dec 21, 2023
Merged

system variable: restored an overidden description about tidb_restricted_read_only #15843

merged 1 commit into from Dec 21, 2023

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Dec 21, 2023 •
edited

First-time contributors' checklist

The original PR: #7670 、 #9718
Part of the content was overidden by this PR 073765f#diff-ec2cbb115cc58fe3afe2862eb5148732d323cbf7ae35dea97bd381a1f8d0e8a0

MdmEg6FdLe

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added contribution Indicates that the PR was contributed by an external member. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2023
@hfxsd hfxsd added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed contribution Indicates that the PR was contributed by an external member. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2023
@hfxsd hfxsd added ONCALL Relates to documentation oncall. translation/no-need No need to translate this PR. labels Dec 21, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 08:10:47.01304938 +0000 UTC m=+1121338.050276307: ☑️ agreed by qiancai.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 21, 2023

/verify

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

@guo-shaoge: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 21, 2023

/approve

@hfxsd hfxsd added the lgtm label Dec 21, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 44c7651 into pingcap:master Dec 21, 2023
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15845.

This was referenced Dec 21, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15846.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 21, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15847.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 21, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15848.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 21, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15849.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot
system variable: restored an overidden description about `tidb_restri…
fed2f81 
…cted_read_only` (#15843) (#15846)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot
system variable: restored an overidden description about `tidb_restri…
ffb32e9 
…cted_read_only` (#15843) (#15845)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot
system variable: restored an overidden description about `tidb_restri…
e0d1767 
…cted_read_only` (#15843) (#15848)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot
system variable: restored an overidden description about `tidb_restri…
9101d07 
…cted_read_only` (#15843) (#15847)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot
system variable: restored an overidden description about `tidb_restri…
b2417e0 
…cted_read_only` (#15843) (#15849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hfxsd @ti-chi-bot @guo-shaoge @qiancai