Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for ALTER SEQUENCE and sequence functions #16649

Merged
merged 12 commits into from Apr 15, 2024
Merged

Add docs for ALTER SEQUENCE and sequence functions #16649

merged 12 commits into from Apr 15, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Feb 29, 2024 •
edited by qiancai

What is changed, added or deleted? (Required)

Closes #16648

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 29, 2024
@dveeden dveeden requested a review from AilinKid March 1, 2024 07:25
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024
@dveeden dveeden changed the title Add docs for ALTER SEQUENCE Add docs for ALTER SEQUENCE and sequence functions Mar 4, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Mar 4, 2024 •
edited

Will try to update this based on pingcap/tidb#51432

Update: Done ✅

AilinKid
AilinKid approved these changes Mar 14, 2024
View reviewed changes
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2024

@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden @AilinKid
Update sql-statements/sql-statement-alter-sequence.md
269dd43 
Co-authored-by: Arenatlx <ailinsilence4@gmail.com>
@qiancai qiancai self-assigned this Mar 14, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 14, 2024
qiancai
qiancai reviewed Mar 22, 2024
View reviewed changes
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-sequence.md Outdated Show resolved Hide resolved
functions-and-operators/sequence-functions.md Outdated Show resolved Hide resolved
functions-and-operators/sequence-functions.md Outdated Show resolved Hide resolved
functions-and-operators/sequence-functions.md Outdated Show resolved Hide resolved
dveeden and others added 4 commits March 22, 2024 16:50
@dveeden @qiancai
Apply suggestions from code review
db4b213 
Co-authored-by: Grace Cai <qqzczy@126.com>
@dveeden @qiancai
Update functions-and-operators/sequence-functions.md
2f4ee79 
Co-authored-by: Grace Cai <qqzczy@126.com>
@dveeden @qiancai
Update sql-statements/sql-statement-alter-sequence.md
b8b3e69 
Co-authored-by: Grace Cai <qqzczy@126.com>
@dveeden @qiancai
Update sql-statements/sql-statement-create-sequence.md
111180c 
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt self-requested a review March 26, 2024 08:38
Oreoxmt
Oreoxmt approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@qiancai @Oreoxmt
Apply suggestions from code review
f819298 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 15, 2024
@qiancai
Copy link
Collaborator

qiancai commented Apr 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-15 03:28:25.508571188 +0000 UTC m=+222324.619617640: ☑️ agreed by Oreoxmt.
  • 2024-04-15 03:31:03.911770637 +0000 UTC m=+222483.022817083: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5642470 into pingcap:master Apr 15, 2024
9 checks passed
@qiancai qiancai added needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 Should cherry pick this PR to release-7.6 branch. labels Apr 16, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17206.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 16, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17207.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 16, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17208.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 16, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@ti-chi-bot
Add docs for ALTER SEQUENCE and sequence functions (#16649) (#17208)
899cbdc
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@ti-chi-bot
Add docs for ALTER SEQUENCE and sequence functions (#16649) (#17207)
13db673
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@ti-chi-bot
Add docs for ALTER SEQUENCE and sequence functions (#16649) (#17206)
0f599d9
@qiancai qiancai mentioned this pull request Apr 26, 2024
Merged
17 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 26, 2024
This was referenced May 9, 2024
Merged
Merged
Merged
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
Add docs for ALTER SEQUENCE and sequence functions (pingcap#16649)
ac97d71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@qiancai qiancai

Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 Should cherry pick this PR to release-7.6 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ALTER SEQUENCE support in TiDB docs
5 participants
@dveeden @qiancai @ti-chi-bot @AilinKid @Oreoxmt