Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic-features.md: add the column for v8.0.0 #16722

Merged
merged 9 commits into from Mar 28, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Mar 12, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Mar 12, 2024
@ti-chi-bot ti-chi-bot bot added contribution Indicates that the PR was contributed by an external member. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 12, 2024
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0 labels Mar 12, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 12, 2024
Copy link

ti-chi-bot bot commented Mar 12, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

basic-features.md Outdated Show resolved Hide resolved
@dveeden
Copy link
Contributor

dveeden commented Mar 20, 2024

@hfxsd maybe we can remove the v4.0 column to ensure this is readable and renders will on desktop, mobile and PDF?

@hfxsd hfxsd added the needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. label Mar 26, 2024
basic-features.md Outdated Show resolved Hide resolved
basic-features.md Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 27, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

basic-features.md Outdated Show resolved Hide resolved
@hfxsd
Copy link
Collaborator Author

hfxsd commented Mar 27, 2024

/retest

Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 02:44:08.574446416 +0000 UTC m=+2122275.596692802: ☑️ agreed by qiancai.
  • 2024-03-28 03:29:22.944063884 +0000 UTC m=+2124989.966310273: ☑️ agreed by Oreoxmt.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Mar 28, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8048fa9 into pingcap:master Mar 28, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution Indicates that the PR was contributed by an external member. lgtm needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants