Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

information-functions: Update reference manual and more #16853

Merged
merged 11 commits into from Apr 25, 2024
Merged

information-functions: Update reference manual and more #16853

merged 11 commits into from Apr 25, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Mar 26, 2024

What is changed, added or deleted? (Required)

Closes #16818

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested a review from mjonss March 26, 2024 12:10
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2024
@dveeden dveeden requested a review from qiancai March 26, 2024 12:10
mjonss
mjonss approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some questions and suggestions.

functions-and-operators/information-functions.md Outdated Show resolved Hide resolved
functions-and-operators/information-functions.md Outdated Show resolved Hide resolved
functions-and-operators/information-functions.md Outdated Show resolved Hide resolved
functions-and-operators/information-functions.md Outdated Show resolved Hide resolved
functions-and-operators/information-functions.md Outdated Show resolved Hide resolved
functions-and-operators/information-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 26, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, with some questions and suggestions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor Author

dveeden commented Mar 29, 2024

@bb7133 Updated this with information from pingcap/tidb#52214 and pingcap/tidb#982

@qiancai qiancai self-assigned this Apr 8, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Apr 8, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 8, 2024
bb7133
bb7133 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 16, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2024
@qiancai
Copy link
Collaborator

qiancai commented Apr 18, 2024 •
edited

Hi @dveeden, I've submitted 0dcbfe4 for description updates. PTAL. Thanks.

@qiancai qiancai mentioned this pull request Apr 23, 2024
Merged
17 tasks
@qiancai qiancai added the type/enhancement This issue/PR improves documentation usability or supplements document content. label Apr 24, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. label Apr 24, 2024
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 24, 2024
@hfxsd hfxsd self-requested a review April 24, 2024 07:41
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-24 06:56:33.693329279 +0000 UTC m=+156950.433232186: ☑️ agreed by qiancai.
  • 2024-04-24 08:06:00.386875704 +0000 UTC m=+161117.126778616: ☑️ agreed by hfxsd.

@dveeden @hfxsd
Update functions-and-operators/information-functions.md
ebe126c 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qiancai
Copy link
Collaborator

qiancai commented Apr 25, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6ee91a9 into pingcap:master Apr 25, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17356.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 25, 2024
@ti-chi-bot
information-functions: Update reference manual and more (#16853) (#17356
9fa0f44 
)
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 25, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@mjonss mjonss mjonss approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update reference manual links in functions-and-operators/information-functions.md
6 participants
@dveeden @qiancai @ti-chi-bot @bb7133 @mjonss @hfxsd