Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: acceleration of snapshot restore speed #16864

Merged
merged 9 commits into from Mar 28, 2024
Merged

br: acceleration of snapshot restore speed #16864

merged 9 commits into from Mar 28, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 27, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0 labels Mar 27, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2024
@lilin90 lilin90 self-requested a review March 27, 2024 09:22
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2024
qiancai
qiancai commented Mar 27, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Mar 27, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 28, 2024

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai commented Mar 28, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 05:28:31.021041627 +0000 UTC m=+2132138.043288015: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Mar 28, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 28, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Mar 28, 2024
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
qiancai
qiancai commented Mar 28, 2024
View reviewed changes
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
br/br-snapshot-guide.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 28, 2024

/approve

@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit ba60122 into pingcap:master Mar 28, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16875.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 28, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 28, 2024
@ti-chi-bot
br: acceleration of snapshot restore speed (#16864) (#16875)
a2d5384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qiancai @ti-chi-bot @lilin90 @BornChanger