Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new order ratio being added to 8.0.0 #16871

Merged
merged 26 commits into from Apr 8, 2024

Conversation

terry1purcell
Copy link
Contributor

@terry1purcell terry1purcell commented Mar 27, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Prior PR added tidb_opt_ordering_index_selectivity_ratio, but this was not documented.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution Indicates that the PR was contributed by an external member. needs-ok-to-test labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

Hi @terry1purcell. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2024
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. v8.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 29, 2024
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd self-assigned this Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 2, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. label Apr 2, 2024
system-variables.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

releases/release-8.0.0.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Apr 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-02 08:16:22.560165609 +0000 UTC m=+345444.087706151: ☑️ agreed by hfxsd.
  • 2024-04-07 06:46:05.086253388 +0000 UTC m=+772026.613793934: ☑️ agreed by Oreoxmt.

releases/release-8.0.0.md Show resolved Hide resolved
system-variables.md Show resolved Hide resolved
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 8, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Apr 8, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 8, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Apr 8, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit e4368ec into pingcap:master Apr 8, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16992.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution Indicates that the PR was contributed by an external member. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. needs-ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants