Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for QUOTE() #16958

Merged
merged 6 commits into from Apr 15, 2024
Merged

Add example for QUOTE() #16958

merged 6 commits into from Apr 15, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 3, 2024

What is changed, added or deleted? (Required)

Closes #16942

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt and qiancai April 3, 2024 12:02
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2024
@Oreoxmt Oreoxmt added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. labels Apr 7, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 7, 2024
@Oreoxmt Oreoxmt added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Apr 7, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 7, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 7, 2024

@dveeden Could you please invite a tech reviewer? Thanks!

@Oreoxmt Oreoxmt removed the request for review from qiancai April 7, 2024 04:18
@dveeden @Oreoxmt
Update functions-and-operators/string-functions.md
5e69e6d 
Co-authored-by: Aolin <aolinz@outlook.com>
@dveeden dveeden requested a review from mjonss April 7, 2024 08:48
@Oreoxmt Oreoxmt mentioned this pull request Apr 7, 2024
Merged
18 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 7, 2024
@dveeden dveeden requested a review from BornChanger April 8, 2024 05:35
lilin90
lilin90 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-07 09:00:16.357068208 +0000 UTC m=+780077.884608754: ☑️ agreed by Oreoxmt.
  • 2024-04-10 03:22:59.323079083 +0000 UTC m=+1019040.850619628: ☑️ agreed by lilin90.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 10, 2024

@mjonss PTAL again

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 10, 2024
Merged
18 tasks
@Oreoxmt Oreoxmt requested a review from mjonss April 10, 2024 09:09
@dveeden dveeden requested a review from bb7133 April 12, 2024 14:09
@bb7133
Copy link
Member

bb7133 commented Apr 12, 2024

LGTM

bb7133
bb7133 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 82e0ff9 into pingcap:master Apr 15, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 15, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17182.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@ti-chi-bot
Add example for QUOTE() (#16958) (#17182)
78eb1fd
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
Add example for QUOTE() (pingcap#16958)
4e02ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@bb7133 bb7133 bb7133 approved these changes

@lilin90 lilin90 lilin90 approved these changes

@BornChanger BornChanger Awaiting requested review from BornChanger

@mjonss mjonss Awaiting requested review from mjonss

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enrich instructions for string functions POSITION() and QUOTE()
6 participants
@dveeden @Oreoxmt @bb7133 @ti-chi-bot @mjonss @lilin90