Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpling: add URI formats #16965

Merged
merged 2 commits into from Apr 7, 2024
Merged

dumpling: add URI formats #16965

merged 2 commits into from Apr 7, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Apr 7, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Apr 7, 2024
@ti-chi-bot ti-chi-bot bot added contribution Indicates that the PR was contributed by an external member. missing-translation-status This PR does not have translation status info. labels Apr 7, 2024
@hfxsd hfxsd requested a review from qiancai April 7, 2024 06:44
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2024
@hfxsd hfxsd added translation/no-need No need to translate this PR. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 Should cherry pick this PR to release-7.6 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 7, 2024
qiancai
qiancai approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

br/backup-and-restore-storages.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-07 07:10:37.053154574 +0000 UTC m=+773498.580695120: ☑️ agreed by qiancai.

@hfxsd @qiancai
Update br/backup-and-restore-storages.md
e36bdf9 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2024
@hfxsd hfxsd added lgtm and removed contribution Indicates that the PR was contributed by an external member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Apr 7, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit a2edc5e into pingcap:master Apr 7, 2024
8 of 9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2024
@hfxsd @ti-chi-bot
This is an automated cherry-pick of pingcap#16965
3e91c42 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2024
Closed
19 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16983.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16984.

This was referenced Apr 7, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16985.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16986.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2024
Merged
19 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16987.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2024
Merged
19 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
dumpling: add URI formats (#16965) (#16985)
ebd9afe
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
dumpling: add URI formats (#16965) (#16987)
81348ca
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
dumpling: add URI formats (#16965) (#16986)
82fee03
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
dumpling: add URI formats (#16965) (#16984)
eb8ef4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 Should cherry pick this PR to release-7.6 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hfxsd @ti-chi-bot @qiancai