Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EBNF for SHOW CREATE DATABASE #17155

Merged
merged 1 commit into from Apr 15, 2024
Merged

Fix EBNF for SHOW CREATE DATABASE #17155

merged 1 commit into from Apr 15, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 11, 2024

What is changed, added or deleted? (Required)

Correct the EBNF for SHOW CREATE DATABASE

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from kennytm and Oreoxmt April 11, 2024 07:36
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 11, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bb7133
bb7133 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/doing This PR's assignee is translating this PR. labels Apr 15, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 15, 2024
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. labels Apr 15, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-15 02:37:49.681993013 +0000 UTC m=+219288.793039461: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt added lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Apr 15, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9cc89a4 into pingcap:master Apr 15, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17183.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 15, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17184.

This was referenced Apr 15, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17185.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@ti-chi-bot
Fix EBNF for SHOW CREATE DATABASE (#17155) (#17183)
63e76fa
ti-chi-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@ti-chi-bot
Fix EBNF for SHOW CREATE DATABASE (#17155) (#17184)
cfa2d7f
ti-chi-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@ti-chi-bot
Fix EBNF for SHOW CREATE DATABASE (#17155) (#17185)
a73b671
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
Fix EBNF for SHOW CREATE DATABASE (pingcap#17155)
b066e3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@bb7133 bb7133 bb7133 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm missing-translation-status This PR does not have translation status info. needs-1-more-lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dveeden @Oreoxmt @ti-chi-bot @kennytm @bb7133