Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#17111) #17162

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #17111

What is changed, added or deleted? (Required)

This pull request adds s3:DeleteObject permission because TiDB 7.1+ checkpoint restore requires it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Fix #16961

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

yahonda and others added 4 commits April 11, 2024 08:44
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot added area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. type/cherry-pick-for-release-7.4 This PR is cherry-picked to release-7.4 from a source PR. labels Apr 11, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Apr 11, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit f54096d into pingcap:release-7.4 Apr 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. type/cherry-pick-for-release-7.4 This PR is cherry-picked to release-7.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants