Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ADMIN SHOW DDL docs #17378

Merged
merged 10 commits into from
May 7, 2024
Merged

Extend ADMIN SHOW DDL docs #17378

merged 10 commits into from
May 7, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 26, 2024

What is changed, added or deleted? (Required)

  • Remove EBNF that's not part of ADMIN SHOW DDL...
  • Add column descriptions for ADMIN SHOW DDL output
  • Change ADMIN SHOW DDL output to vertical to make it more readable
  • Add some common JOB_TYPE's
  • Add description for CREATE_TIME and END_TIME for the ADMIN SHOW DDL JOBS output.
  • Add more links to the See also
  • Fix EBNF to add LIMIT n,m in addition to LIMIT n OFFSET m. (Thanks @kennytm )

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Apr 26, 2024

For reference, output from ADMIN SHOW DDL with a running job. This is with unistore instead of TiKV, so I'm not 100% sure how representative this is.

mysql> admin show ddl\G
*************************** 1. row ***************************
   SCHEMA_VER: 5055
     OWNER_ID: eef31ae6-14a2-4664-85d7-dc842ccd62e4
OWNER_ADDRESS: 192.168.1.229:4000
 RUNNING_JOBS: ID:10106, Type:add index, State:running, SchemaState:write reorganization, SchemaID:2, TableID:10104, RowCount:1447630, ArgLen:0, start time: 2024-04-26 11:20:02.291 +0200 CEST, Err:<nil>, ErrCount:0, SnapshotVersion:449347112749760513, LocalMode: false, UniqueWarnings:0
      SELF_ID: eef31ae6-14a2-4664-85d7-dc842ccd62e4
        QUERY: alter table t1 add index (c1(100))
1 row in set (0.00 sec)

Co-authored-by: kennytm <kennytm@gmail.com>
sql-statements/sql-statement-admin-show-ddl.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Apr 26, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: kennytm <kennytm@gmail.com>
Copy link

ti-chi-bot bot commented Apr 27, 2024

@lyzx2001: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Apr 30, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Apr 30, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 30, 2024
@qiancai qiancai added type/enhancement This issue/PR improves documentation usability or supplements document content. missing-translation-status This PR does not have translation status info. and removed missing-translation-status This PR does not have translation status info. labels Apr 30, 2024
dveeden and others added 2 commits April 30, 2024 10:03
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Copy link

ti-chi-bot bot commented May 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-06 03:10:25.596451461 +0000 UTC m=+845179.353587035: ☑️ agreed by qiancai.

dveeden and others added 2 commits May 6, 2024 11:43
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Copy link

ti-chi-bot bot commented May 7, 2024

@qiancai: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented May 7, 2024

/approve

@qiancai qiancai added the lgtm label May 7, 2024
Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8ece8d8 into pingcap:master May 7, 2024
9 checks passed
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 8, 2024
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants