Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTO_INCREMENT: update keyword auto_increment to CAPS #1746

Closed

Conversation

kana112233
Copy link
Contributor

What is changed, added or deleted?

did: update keyword auto_increment to AUTO_INCREMENT
why: issue: #699
"In #695 we determined that SQL keywords should be in all caps. There are a number of pages that require updating."

What is the related PR or file link(s)?

N/A

Which version does your change affect?

dev/v1.0/v2.0/v2.1/v2.1-legacy/v3.0/v3.1

@yikeke
Copy link
Contributor

yikeke commented Jan 7, 2020

Thanks for your contribution! @kana112233 Please sign the CLA so we can get this pull request merged later.

@yikeke yikeke self-requested a review January 7, 2020 07:26
@yikeke yikeke added contribution Indicates that the PR was contributed by an external member. translation/doing This PR's assignee is translating this PR. labels Jan 7, 2020
@yikeke yikeke requested a review from kennytm January 7, 2020 07:28
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the size/small Changes of a small size. label Jan 7, 2020
@kana112233
Copy link
Contributor Author

sign the CLA

I can't sign the CLA by username: makey22112, #1750 is new PR.

@kana112233 kana112233 closed this Jan 7, 2020
@kana112233 kana112233 reopened this Jan 8, 2020
@kana112233 kana112233 closed this Jan 8, 2020
@yikeke yikeke removed the translation/doing This PR's assignee is translating this PR. label Jan 8, 2020
@kana112233 kana112233 deleted the fix-keyword-auto_increment branch January 8, 2020 05:54
@CLAassistant
Copy link

CLAassistant commented May 1, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ yikeke
✅ kana112233
❌ makey22112


makey22112 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Indicates that the PR was contributed by an external member. size/small Changes of a small size.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants