Document pre/post upgrade and reload scripts #17611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
missing-translation-status
kaaaaaaang
approved these changes
May 27, 2024
|
@kaaaaaaang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
removed
the
missing-translation-status
qiancai
added
area/tiup
qiancai
approved these changes
Jun 17, 2024
Comment on lines
+88
to
+90
| - Run a script before the reload. | ||
| - Data type: `STRINGS` | ||
| - This option specifies the path of the command that will be ran on the host that is to be reloaded. |
There was a problem hiding this comment.
Suggested change
| - Run a script before the reload. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of the command that will be ran on the host that is to be reloaded. | |
| - Runs a script before the reload. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of a script to be run on the host that is to be reloaded. |
Comment on lines
+98
to
+100
| - Run a script after the reload. | ||
| - Data type: `STRINGS` | ||
| - This option specifies the path of the command that will be ran on the host that was reloaded. |
There was a problem hiding this comment.
Suggested change
| - Run a script after the reload. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of the command that will be ran on the host that was reloaded. | |
| - Runs a script after the reload. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of a script to be run after the reload of a host. |
Comment on lines
+131
to
+133
| - Run a script before the upgrade. | ||
| - Data type: `STRINGS` | ||
| - This option specifies the path of the command that will be ran on the host that is to be upgraded. |
There was a problem hiding this comment.
Suggested change
| - Run a script before the upgrade. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of the command that will be ran on the host that is to be upgraded. | |
| - Runs a script before the upgrade. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of a script to be run on the host that is to be upgraded. |
Comment on lines
+141
to
+143
| - Run a script after the upgrade. | ||
| - Data type: `STRINGS` | ||
| - This option specifies the path of the command that will be ran after the upgrade of a host. This command will be executed on the upgraded host itself. |
There was a problem hiding this comment.
Suggested change
| - Run a script after the upgrade. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of the command that will be ran after the upgrade of a host. This command will be executed on the upgraded host itself. | |
| - Runs a script after the upgrade. | |
| - Data type: `STRINGS` | |
| - This option specifies the path of a script to be run after the upgrade of a host. This command will be executed on the upgraded host itself. |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
pingcap/tiup#2130
Do your changes match any of the following descriptions?