Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releases: add deprecated note in titles #2437

Merged
merged 6 commits into from
May 13, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 30, 2020

What is changed, added or deleted? (Required)

Add deprecated note in titles.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.0 labels Apr 30, 2020
@TomShawn TomShawn requested review from scsldb and lilin90 April 30, 2020 08:58
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Release date: February 20, 2020

TiDB version: 3.0.10

TiDB Ansible version: 3.0.10

> **Warning:**
>
> This version is deprecated.
Copy link
Member

@lilin90 lilin90 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scsldb

  • How about suggesting that users choose a specific version? So users know which version to use.
  • Please help confirm whether it's appropriate to say deprecated here. Users might be confused. Would it be better to give some explanations?

@TomShawn TomShawn requested a review from yikeke May 9, 2020 13:04
@ran-huang ran-huang added the status/PTAL This PR is ready for reviewing. label May 12, 2020
@lilin90 lilin90 added this to PR: In Progress in Docs SIG May 13, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 46788f2 into pingcap:master May 13, 2020
Docs SIG automation moved this from PR: In Progress to PR: Done May 13, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

cherry pick to release-3.0 in PR #2550

sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

cherry pick to release-3.1 in PR #2551

sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

cherry pick to release-4.0 in PR #2552

@TomShawn TomShawn deleted the deprecated-releases branch May 13, 2020 11:37
sre-bot added a commit that referenced this pull request May 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot added a commit that referenced this pull request May 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
No open projects
Docs SIG
  
PR: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants