performance tuning: change SQL tuning TOC #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
This was referenced Sep 10, 2020
TomShawn
added
size/small
SunRunAway
reviewed
Sep 10, 2020
|
@SunRunAway,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack). |
|
@lilin90 PTAL |
ghost
mentioned this pull request
|
@zz-jason, @SunRunAway, @kissmydb, @lilin90, PTAL. |
1 similar comment
|
@zz-jason, @SunRunAway, @kissmydb, @lilin90, PTAL. |
lilin90
reviewed
Sep 15, 2020
Comment on lines
+114
to
+115
| + Understanding the Query Execution Plan | ||
| + [Overview](/explain-overview.md) |
There was a problem hiding this comment.
- Since we don't have multiple topics about query execution plan now, how about keeping one line?
- Is it a must to change the file name from
query-execution-plan.mdtoexplain-overview.md? Because we'll try to avoid changing file names unless it's really necessary, to make it easy to maintain documentation (Let's avoid using too many aliases and try to keep the URL stable if possible).
Suggested change
| + Understanding the Query Execution Plan | |
| + [Overview](/explain-overview.md) | |
| + [Understanding the Query Execution Plan](/explain-overview.md) |
There was a problem hiding this comment.
Got it. Just to confirm: by "keep it as is", I think you mean keeping your changes, right? And the newly added content in two other PRs will be put under "Understanding the Query Execution Plan"?
There was a problem hiding this comment.
That is correct. The TOC I proposed to the SQL team is as follows:
Understanding the Query Execution Plan
Overview
Explain Walkthough
Indexes
Joins
Subqueries
Views
Partitions
9 tasks
9 tasks
This was referenced Sep 17, 2020
Merged
ti-srebot
approved these changes
Sep 29, 2020
lilin90
added
size/medium
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Sep 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
|
cherry pick to release-4.0 in PR #3988 |
ghost
pushed a commit
that referenced
this pull request
Sep 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
9 tasks
TomShawn
added
translation/done
9 tasks
This was referenced Oct 15, 2020
9 tasks
9 tasks
This was referenced Nov 4, 2020
9 tasks
ghost
mentioned this pull request
9 tasks
9 tasks
9 tasks
9 tasks
This was referenced Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
This changes the SQL tuning TOC to follow the same structure as in the overview (which I've improved to make clearer - mentioning that SQL is declarative etc).
I am trying to make this change small, with additional content under
SQL Tuning > Understanding the Query Execution Planto follow in separate PRs.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?