Update commands and tool info about key-type
#7305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-jin19
added
type/enhancement
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
size/S
en-jin19
added
needs-cherry-pick-release-5.4
lhy1024
approved these changes
Feb 14, 2022
en-jin19
added
translation/from-docs-cn
en-jin19
changed the title
key-typekey-type
en-jin19
commented
Mar 4, 2022
en-jin19
commented
Mar 4, 2022
en-jin19
commented
Mar 9, 2022
| - Set `key-type` to `"txn"` or `"raw"`. You can modify the parameter dynamically. | ||
| - Or keep `key-type` as `table` and set `enable-cross-table-merge` to `true`. You can modify the parameter dynamically. | ||
| - PD: You can use PD Control to selectively set the following parameters according to the cluster situation. | ||
| - Suppose that the cluster has no TiDB instance, and the value of [`key-type`](/pd-control.md#config-show--set-option-value--placement-rules) is set to `raw` or `txn`. In this case, PD can merge Regions across tables, regardless of what value of `enable-cross-table-merge setting` is set to. You can modify the `key-type` parameter dynamically. |
There was a problem hiding this comment.
Suggested change
| - Suppose that the cluster has no TiDB instance, and the value of [`key-type`](/pd-control.md#config-show--set-option-value--placement-rules) is set to `raw` or `txn`. In this case, PD can merge Regions across tables, regardless of what value of `enable-cross-table-merge setting` is set to. You can modify the `key-type` parameter dynamically. | |
| - Suppose that your cluster has no TiDB instance, and the value of [`key-type`](/pd-control.md#config-show--set-option-value--placement-rules) is set to `raw` or `txn`. In this case, PD can merge Regions across tables, regardless of the value of `enable-cross-table-merge setting`. You can modify the `key-type` parameter dynamically. |
en-jin19
commented
Mar 9, 2022
| config set key-type txn | ||
| ``` | ||
|
|
||
| - Suppose that the cluster has a TiDB instance, and the value of `key-type` is set to "table". In this case, PD can merge Regions across tables only if the value of `enable-cross-table-merge` is set to `true`. You can modify the `key-type` parameter dynamically. |
There was a problem hiding this comment.
Suggested change
| - Suppose that the cluster has a TiDB instance, and the value of `key-type` is set to "table". In this case, PD can merge Regions across tables only if the value of `enable-cross-table-merge` is set to `true`. You can modify the `key-type` parameter dynamically. | |
| - Suppose that your cluster has a TiDB instance, and the value of `key-type` is set to `table`. In this case, PD can merge Regions across tables only if the value of `enable-cross-table-merge` is set to `true`. You can modify the `key-type` parameter dynamically. |
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
|
/merge |
|
@en-jin19: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: ed8fb48
|
ti-chi-bot
added
the
status/can-merge
13 tasks
|
In response to a cherrypick label: new pull request created: #7853. |
13 tasks
|
In response to a cherrypick label: new pull request created: #7854. |
13 tasks
|
In response to a cherrypick label: new pull request created: #7855. |
ti-chi-bot
added a commit
that referenced
this pull request
Mar 14, 2022
ti-chi-bot
added a commit
that referenced
this pull request
Mar 14, 2022
ti-chi-bot
added a commit
that referenced
this pull request
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update commands and tool info about
key-typeWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
key-typedocs-cn#7758Do your changes match any of the following descriptions?