New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tidb_dml_batch_size section #7371
Conversation
tidb_dml_batch_size is only effective when another variable is turned on 'tidb_batch_insert', however it is not documented causing some confusion for customer
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Can you also add:
|
commit new change according to morgan's suggestion Co-authored-by: Morgan Tocker <tocker@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@morgo PTAL. Thanks~ |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 03f5bf0
|
In response to a cherrypick label: new pull request created: #8220. |
In response to a cherrypick label: new pull request created: #8221. |
In response to a cherrypick label: new pull request created: #8223. |
* Update tidb_dml_batch_size section tidb_dml_batch_size is only effective when another variable is turned on 'tidb_batch_insert', however it is not documented causing some confusion for customer * Update system-variables.md commit new change according to morgan's suggestion Co-authored-by: Morgan Tocker <tocker@gmail.com> * Update system-variables.md * Update system-variables.md * Update system-variables.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update system-variables.md Co-authored-by: leowangpingcap <89871841+leowangpingcap@users.noreply.github.com> Co-authored-by: Morgan Tocker <tocker@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
tidb_dml_batch_size is only effective when another variable is turned on 'tidb_batch_insert',
however it is not documented causing some confusion for customer
What is changed, added or deleted? (Required)
added
'tidb_batch_insert' parameter is required to turn on in order for 'tidb_dml_batch_size' to work, but information is currently missing in the doc
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
No reference link, internal TSE suggestion
Do your changes match any of the following descriptions?