Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Amazon Linux 2 as supported #7473

Merged
merged 1 commit into from
Mar 14, 2022
Merged

List Amazon Linux 2 as supported #7473

merged 1 commit into from
Mar 14, 2022

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 25, 2022

What is changed, added or deleted? (Required)

List Amazon Linux 2 (CentOS 7 based) as supported. This is common OS when deploying on ARM64 (AWS Graviton 2)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 25, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2022
@shichun-0415 shichun-0415 self-assigned this Jan 26, 2022
@shichun-0415 shichun-0415 added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jan 26, 2022
@shichun-0415 shichun-0415 added area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. type/enhancement This issue/PR improves documentation usability or supplements document content. labels Jan 26, 2022
@TomShawn TomShawn requested review from lilyjazz, qqqdan, easonn7 and shuke987 and removed request for AstroProfundis January 26, 2022 10:56
@dveeden dveeden mentioned this pull request Jan 27, 2022
Merged
shichun-0415
shichun-0415 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 14, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: af9127a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@ti-chi-bot ti-chi-bot merged commit 45ce64a into pingcap:master Mar 14, 2022
@shichun-0415 shichun-0415 mentioned this pull request Mar 14, 2022
Merged
16 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqqdan qqqdan qqqdan approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

@lilyjazz lilyjazz Awaiting requested review from lilyjazz

@easonn7 easonn7 Awaiting requested review from easonn7

@shuke987 shuke987 Awaiting requested review from shuke987

Assignees

@shichun-0415 shichun-0415

Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dveeden @ti-chi-bot @shichun-0415 @qqqdan