Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: clarify rules and policies #7823

Merged
merged 12 commits into from
Mar 14, 2022
Merged

*: clarify rules and policies #7823

merged 12 commits into from
Mar 14, 2022

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Mar 10, 2022 •
edited

Signed-off-by: xhe xw897002528@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

A follow up from pingcap/docs-cn#8230:

  1. add descriptions on placement rules and placement policies
  2. remove one more direct placement in information-schema-placement-rules.md
  3. refine one example

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@xhebox
*: clarify rules and policies
3d3f435 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested review from morgo and TomShawn March 10, 2022 07:59
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2022
@xhebox xhebox mentioned this pull request Mar 10, 2022
Merged
15 tasks
TomShawn
TomShawn reviewed Mar 10, 2022
View reviewed changes
information-schema/information-schema-placement-rules.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
information-schema/information-schema-placement-rules.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 10, 2022
View reviewed changes
placement-rules-in-sql.md Outdated Show resolved Hide resolved
xhebox and others added 10 commits March 10, 2022 16:54
@xhebox @TomShawn
Update information-schema/information-schema-placement-rules.md
0f80f08 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
0122a95 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
a692825 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
0f94b0f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
03adb56 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
e6b51b5 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
8462222 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
21ca55c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update information-schema/information-schema-placement-rules.md
3568714 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xhebox @TomShawn
Update placement-rules-in-sql.md
fa02538 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v6.0 This PR/issue applies to TiDB v6.0. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed missing-translation-status This PR does not have translation status info. labels Mar 11, 2022
TomShawn
TomShawn approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2022
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fa02538

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@ti-chi-bot ti-chi-bot merged commit d8f06c5 into pingcap:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xhebox @ti-chi-bot @TomShawn @morgo @shichun-0415