Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binlog deploy configuration #7990

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 30, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

There are 3 directories in TiUP configuration, drainer's data_dir (generated by global config), drainer's config.data-dir, and drainer's config.syncer.to.dir.

The priority of this is drainer_servers.config.syncer.to.dir > drainer_servers.data_dir > drainer.config.data-dir, so the data-dir is adjusted to the higher priority version here.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-4.0 area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Mar 30, 2022
@Oreoxmt Oreoxmt requested a review from lichunzhu March 30, 2022 10:48
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2022
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 30, 2022

I've finished the self-check of this PR. PTAL

@Oreoxmt Oreoxmt requested a review from TomShawn March 30, 2022 10:49
@Oreoxmt Oreoxmt self-assigned this Mar 30, 2022
@Oreoxmt Oreoxmt requested review from ran-huang and removed request for TomShawn April 6, 2022 10:02
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f83a3d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@ti-chi-bot ti-chi-bot merged commit 65f6cd6 into pingcap:master Apr 12, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8154.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8155.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8156.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8157.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8158.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants