Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify configuration description for disable-auto-compactions and fix typo #7997

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Modify configuration description for disable-auto-compactions and fix typo #7997

merged 3 commits into from
Apr 7, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 31, 2022 •
edited by ymkzpx

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Modify configuration description for disable-auto-compactions
  • Change value "true" to true

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-4.0 area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Mar 31, 2022
@Oreoxmt Oreoxmt self-assigned this Mar 31, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 31, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 31, 2022
@Oreoxmt Oreoxmt requested a review from ran-huang March 31, 2022 11:11
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 6, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bcf9474

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@ti-chi-bot ti-chi-bot merged commit f08f7a1 into pingcap:master Apr 7, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2022
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#7997
1e528fc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8112.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2022
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#7997
5e22a68 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8113.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2022
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#7997
3fa3537 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8114.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8115.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2022
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#7997
3ee903f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8116.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2022
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#7997
39b7960 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8117.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2022
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#7997
d8e6424 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8118.

ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@ti-chi-bot
Modify configuration description for disable-auto-compactions and fix…
f8e862f 
… typo (#7997) (#8115)
Oreoxmt added a commit to ti-chi-bot/docs that referenced this pull request Apr 7, 2022
@Oreoxmt
This is an automated cherry-pick of pingcap#7997
da9f666 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
shichun-0415 pushed a commit that referenced this pull request Apr 11, 2022
@ti-chi-bot @Oreoxmt
Modify configuration description for disable-auto-compactions and fix…
7a230a8 
… typo (#7997) (#8118)

* This is an automated cherry-pick of #7997

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve conflict

Co-authored-by: Aolin <60599231+Oreoxmt@users.noreply.github.com>
Co-authored-by: Oreoxmt <aolinz@outlook.com>
shichun-0415 pushed a commit that referenced this pull request Apr 11, 2022
@ti-chi-bot @Oreoxmt
Modify configuration description for disable-auto-compactions and fix…
21ca0a9 
… typo (#7997) (#8117)

* This is an automated cherry-pick of #7997

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve conflict

Co-authored-by: Aolin <60599231+Oreoxmt@users.noreply.github.com>
Co-authored-by: Oreoxmt <aolinz@outlook.com>
ti-chi-bot added a commit that referenced this pull request Apr 11, 2022
@ti-chi-bot
Modify configuration description for disable-auto-compactions and fix…
c313b20 
… typo (#7997) (#8116)
ti-chi-bot added a commit that referenced this pull request Apr 11, 2022
@ti-chi-bot
Modify configuration description for disable-auto-compactions and fix…
4ef9a7a 
… typo (#7997) (#8114)
ti-chi-bot added a commit that referenced this pull request Apr 11, 2022
@ti-chi-bot
Modify configuration description for disable-auto-compactions and fix…
3b23b6d 
… typo (#7997) (#8112)
ti-chi-bot added a commit that referenced this pull request Apr 12, 2022
@ti-chi-bot
Modify configuration description for disable-auto-compactions and fix…
8146996 
… typo (#7997) (#8113)
@Oreoxmt Oreoxmt deleted the translate/docs-cn/#8793 branch May 6, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Oreoxmt @ti-chi-bot @ran-huang @TomShawn