Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PingCAP Clinic: update contents for v6.0 #8035

Merged
merged 14 commits into from
Apr 2, 2022
Merged

PingCAP Clinic: update contents for v6.0 #8035

merged 14 commits into from
Apr 2, 2022

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Apr 1, 2022 •
edited by qiancai

What is changed, added or deleted? (Required)

Update version info, descriptions, and commands for v6.0.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.0 This PR/issue applies to TiDB v6.0. area/clinic This PR relates to the area of TiDB Clinic. needs-cherry-pick-release-6.0 labels Apr 1, 2022
@en-jin19 en-jin19 requested review from qqqdan and qiancai April 1, 2022 11:51
@en-jin19 en-jin19 self-assigned this Apr 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2022
qqqdan
qqqdan approved these changes Apr 2, 2022
View reviewed changes
clinic/clinic-data-instruction-for-tiup.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Apr 2, 2022
View reviewed changes
clinic/clinic-data-instruction-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-introduction.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-user-guide-for-tiup.md Outdated Show resolved Hide resolved
@en-jin19 @qiancai
Apply suggestions from code review
89414ae 
Co-authored-by: Grace Cai <qqzczy@126.com>
qiancai
qiancai approved these changes Apr 2, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2022
@en-jin19 @qiancai
Apply suggestions from code review
ecacb5a 
Co-authored-by: Grace Cai <qqzczy@126.com>
@en-jin19
Copy link
Contributor Author

en-jin19 commented Apr 2, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2022
@en-jin19
Copy link
Contributor Author

en-jin19 commented Apr 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ecacb5a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2022
@ti-chi-bot ti-chi-bot merged commit 388e84c into pingcap:master Apr 2, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 2, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8064.

ti-chi-bot added a commit that referenced this pull request Apr 2, 2022
@ti-chi-bot
PingCAP Clinic: update contents for v6.0 (#8035) (#8064)
8db73b9
@en-jin19 en-jin19 mentioned this pull request Apr 20, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqqdan qqqdan qqqdan approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@en-jin19 en-jin19

Labels
area/clinic This PR relates to the area of TiDB Clinic. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@en-jin19 @ti-chi-bot @qqqdan @qiancai