Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alter partition demo in placement in sql #8071

Merged
merged 3 commits into from Apr 6, 2022
Merged

Add alter partition demo in placement in sql #8071

merged 3 commits into from Apr 6, 2022

Conversation

lcwangchao
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2022
@lcwangchao lcwangchao mentioned this pull request Apr 6, 2022
Merged
16 tasks
@morgo morgo self-requested a review April 6, 2022 04:10
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2022
@shichun-0415 shichun-0415 requested review from TomShawn and removed request for shichun-0415 April 6, 2022 04:57
@shichun-0415 shichun-0415 added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 6, 2022
@TomShawn TomShawn added the v6.0 This PR/issue applies to TiDB v6.0. label Apr 6, 2022
TomShawn
TomShawn reviewed Apr 6, 2022
View reviewed changes
placement-rules-in-sql.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 6, 2022
Merged
16 tasks
TomShawn
TomShawn approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 6, 2022
TomShawn
TomShawn reviewed Apr 6, 2022
View reviewed changes
placement-rules-in-sql.md Outdated Show resolved Hide resolved
@TomShawn TomShawn changed the title Update placement-rules-in-sql.md Add alter partition demo in placement in sql Apr 6, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Apr 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a31e0d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2022
@ti-chi-bot ti-chi-bot merged commit 298e348 into master Apr 6, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 6, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8072.

@TomShawn TomShawn deleted the lcwangchao-patch-2 branch April 6, 2022 05:44
ti-chi-bot added a commit that referenced this pull request Apr 6, 2022
@ti-chi-bot
Add alter partition demo in placement in sql (#8071) (#8072)
99faac3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lcwangchao @ti-chi-bot @TomShawn @morgo @shichun-0415