Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: refactor dm docs - part 2 #8207

Merged
merged 4 commits into from Apr 19, 2022
Merged

dm: refactor dm docs - part 2 #8207

merged 4 commits into from Apr 19, 2022

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Apr 13, 2022 •
edited

What is changed, added or deleted? (Required)

Update quick start guide and task configuration file full.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
update task-config-full
744a24a 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang
align quick-start-with-dm.md
8429c74 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/dm labels Apr 13, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2022
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 13, 2022
@ran-huang ran-huang marked this pull request as ready for review April 14, 2022 06:42
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2022
@ran-huang ran-huang requested review from sunzhaoyang and hfxsd and removed request for TomShawn April 14, 2022 06:42
@ran-huang ran-huang added the type/refactor Reorganizes the documentation structure. label Apr 14, 2022
sunzhaoyang
sunzhaoyang approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@sunzhaoyang sunzhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hfxsd
hfxsd approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2022
@ran-huang @hfxsd
Apply suggestions from code review
f5aadcb 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@ran-huang
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2022
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0c1ecfe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2022
@ti-chi-bot ti-chi-bot merged commit b4fb9c4 into pingcap:master Apr 19, 2022
@ran-huang ran-huang deleted the dm-refactor branch April 19, 2022 12:40
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 19, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8273.

ti-chi-bot added a commit that referenced this pull request Apr 19, 2022
@ti-chi-bot
dm: refactor dm docs - part 2 (#8207) (#8273)
6505619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhaoyang sunzhaoyang sunzhaoyang approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees
No one assigned
Labels
area/dm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/refactor Reorganizes the documentation structure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ran-huang @ti-chi-bot @sunzhaoyang @hfxsd