Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiKV Config: add override information about some configuration items #8375

Merged
merged 3 commits into from
May 5, 2022
Merged

TiKV Config: add override information about some configuration items #8375

merged 3 commits into from
May 5, 2022

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Apr 26, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added override information about some configuration items.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 labels Apr 26, 2022
@en-jin19 en-jin19 self-assigned this Apr 26, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 26, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2022
Connor1996
Connor1996 approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@en-jin19 en-jin19 added the status/PTAL This PR is ready for reviewing. label Apr 26, 2022
en-jin19
en-jin19 commented Apr 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Apr 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Apr 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Apr 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Apr 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Apr 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Apr 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@en-jin19
Copy link
Contributor Author

en-jin19 commented Apr 29, 2022 •
edited

@TomShawn Issues have been fixed, PTAL, thank you!

TomShawn
TomShawn reviewed May 5, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed May 5, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed May 5, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed May 5, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022
@en-jin19
Copy link
Contributor Author

en-jin19 commented May 5, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2022
@en-jin19
Copy link
Contributor Author

en-jin19 commented May 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 067bac2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@ti-chi-bot ti-chi-bot merged commit ab96612 into pingcap:master May 5, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 5, 2022
@en-jin19 @ti-chi-bot
This is an automated cherry-pick of pingcap#8375
a7d1b8d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 5, 2022
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8449.

@ti-chi-bot ti-chi-bot mentioned this pull request May 5, 2022
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8450.

@ti-chi-bot ti-chi-bot mentioned this pull request May 5, 2022
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8451.

@ti-chi-bot ti-chi-bot mentioned this pull request May 5, 2022
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8452.

@en-jin19 en-jin19 removed the status/PTAL This PR is ready for reviewing. label May 5, 2022
ti-chi-bot added a commit that referenced this pull request May 5, 2022
@ti-chi-bot
TiKV Config: add override information about some configuration items (#…
4869b11 
…8375) (#8451)
ti-chi-bot added a commit that referenced this pull request May 5, 2022
@ti-chi-bot
TiKV Config: add override information about some configuration items (#…
b91ab9c 
…8375) (#8450)
ti-chi-bot added a commit that referenced this pull request May 5, 2022
@ti-chi-bot
TiKV Config: add override information about some configuration items (#…
495891d 
…8375) (#8452)
ti-chi-bot added a commit that referenced this pull request May 5, 2022
@ti-chi-bot
TiKV Config: add override information about some configuration items (#…
cfc1ee8 
…8375) (#8449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@en-jin19 en-jin19

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@en-jin19 @ti-chi-bot @Connor1996 @TomShawn