Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TiKV API V2 docs #8719

Merged
merged 11 commits into from Jun 7, 2022
Merged

Add TiKV API V2 docs #8719

merged 11 commits into from Jun 7, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented May 24, 2022 •
edited

What is changed, added or deleted? (Required)

Add TiKV API V2 docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2022
@TomShawn TomShawn requested review from pingyu and Oreoxmt May 24, 2022 13:32
@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. v6.1 This PR/issue applies to TiDB v6.1. and removed missing-translation-status This PR does not have translation status info. labels May 24, 2022
pingyu
pingyu reviewed May 30, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn @pingyu
Apply suggestions from code review
e8d9a71 
Co-authored-by: Ping Yu <shui.yu@126.com>
pingyu
pingyu reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM~

tikv-configuration-file.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jun 6, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn and others added 2 commits June 6, 2022 12:50
@TomShawn @pingyu
Update tikv-configuration-file.md
5aa1729 
Co-authored-by: Ping Yu <shui.yu@126.com>
@TomShawn @Oreoxmt
Apply suggestions from code review
e5d8c5d 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt reviewed Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 7, 2022
@TomShawn @Oreoxmt
Apply suggestions from code review
7732900 
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
TomShawn
TomShawn commented Jun 7, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn TomShawn requested review from pingyu and Oreoxmt June 7, 2022 04:12
pingyu
pingyu approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

TomShawn
TomShawn commented Jun 7, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Jun 7, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Jun 7, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Jun 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 581971f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2022
@ti-chi-bot ti-chi-bot merged commit af776c5 into pingcap:master Jun 7, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8820.

@TomShawn TomShawn deleted the 6.1-api-v2 branch June 7, 2022 10:06
ti-chi-bot added a commit that referenced this pull request Jun 7, 2022
@ti-chi-bot
Add TiKV API V2 docs (#8719) (#8820)
4cfaa5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingyu pingyu pingyu approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees
No one assigned
Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TomShawn @ti-chi-bot @pingyu @Oreoxmt