Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool: update the tool downloading links and instructions #8839

Merged
merged 7 commits into from Jun 9, 2022
Merged

tool: update the tool downloading links and instructions #8839

merged 7 commits into from Jun 9, 2022

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jun 8, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 8, 2022 08:18
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2022
@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jun 8, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 8, 2022
@qiancai qiancai requested review from ran-huang and shichun-0415 and removed request for TomShawn June 8, 2022 08:19
@qiancai qiancai added the type/enhancement This issue/PR improves documentation usability or supplements document content. label Jun 8, 2022
qiancai
qiancai commented Jun 8, 2022
View reviewed changes
download-ecosystem-tools.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Jun 8, 2022
View reviewed changes
dumpling-overview.md Outdated Show resolved Hide resolved
@qiancai qiancai added needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jun 8, 2022
ran-huang
ran-huang reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

download-ecosystem-tools.md Outdated Show resolved Hide resolved
tidb-binlog/tidb-binlog-reparo.md
@@ -8,7 +8,7 @@ aliases: ['/docs/dev/tidb-binlog/tidb-binlog-reparo/','/docs/dev/reference/tidb-

Reparo is a TiDB Binlog tool, used to recover the incremental data. To back up the incremental data, you can use Drainer of TiDB Binlog to output the binlog data in the protobuf format to files. To restore the incremental data, you can use Reparo to parse the binlog data in the files and apply the binlog in TiDB/MySQL.

Download Reparo via [tidb-binlog-cluster-latest-linux-amd64.tar.gz](https://download.pingcap.org/tidb-binlog-cluster-latest-linux-amd64.tar.gz)
The Reparo installation package (`reparo`) is included in the TiDB Toolkit. To download the TiDB Toolkit, see [Download TiDB Tools](/download-ecosystem-tools.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidb-binlog/get-started-with-tidb-binlog.md 这个文档漏掉了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 641045c

qiancai and others added 2 commits June 9, 2022 16:23
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2022
@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 9, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 641045c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2022
@ti-chi-bot ti-chi-bot merged commit d3091b4 into pingcap:master Jun 9, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8863.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8864.

ti-chi-bot added a commit that referenced this pull request Jun 9, 2022
@ti-chi-bot
tool: update the tool downloading links and instructions (#8839) (#8863)
66456b6
ti-chi-bot added a commit that referenced this pull request Jun 9, 2022
@ti-chi-bot
tool: update the tool downloading links and instructions (#8839) (#8864)
ee8f1cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@shichun-0415 shichun-0415 Awaiting requested review from shichun-0415

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qiancai @ti-chi-bot @ran-huang