Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate gc-merge-rewrite #8901

Merged
merged 1 commit into from Aug 2, 2022
Merged

deprecate gc-merge-rewrite #8901

merged 1 commit into from Aug 2, 2022

Conversation

tabokie
Copy link
Contributor

@tabokie tabokie commented Jun 10, 2022

Signed-off-by: tabokie xy.tao@outlook.com

What is changed, added or deleted? (Required)

tikv/tikv#12798

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

@tabokie
deprecate gc-merge-rewrite
d4e4af9 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 10, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 10, 2022 10:12
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2022
@shichun-0415 shichun-0415 added translation/doing This PR's assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Jun 13, 2022
@shichun-0415 shichun-0415 requested review from Oreoxmt and removed request for TomShawn June 13, 2022 01:08
TomShawn
TomShawn reviewed Jun 13, 2022
View reviewed changes
tikv-configuration-file.md
@@ -1300,11 +1300,6 @@ Configuration items related to `rocksdb.defaultcf.titan`.
+ Determines whether to optimize the read performance. When `level-merge` is enabled, there is more write amplification.
+ Default value: `false`

### `gc-merge-rewrite`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which version is this config deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it will be deprecated in v6.2, right? Also, deprecation is not the same as deletion. Deprecation means that you are not recommended to but can still use it. Deletion is performed on the code side, then on the doc side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User can still configure it. But they cannot start TiKV with it enabled.

@Oreoxmt Oreoxmt requested a review from Connor1996 June 13, 2022 02:38
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 13, 2022
Connor1996
Connor1996 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label Jun 20, 2022
@shichun-0415 shichun-0415 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v6.2 This PR/issue applies to TiDB v6.2. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Jun 20, 2022
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@Oreoxmt Oreoxmt mentioned this pull request Jul 21, 2022
Merged
13 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 21, 2022
@Oreoxmt Oreoxmt closed this Jul 21, 2022
@Oreoxmt Oreoxmt reopened this Jul 21, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 27, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d4e4af9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2022
@ti-chi-bot ti-chi-bot merged commit 289d09f into pingcap:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@Connor1996 Connor1996 Connor1996 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tabokie @ti-chi-bot @Oreoxmt @Connor1996 @TomShawn @shichun-0415