New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max-days
and max-backups
default value 0 means for PD
#9330
Add max-days
and max-backups
default value 0 means for PD
#9330
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
max-days
and max-backups
default value 0 means for PD configu…max-days
and max-backups
default value 0 means for PD
ebbbd67
to
bd87e61
Compare
/status LGT1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bd87e61
|
In response to a cherrypick label: new pull request created: #9915. |
In response to a cherrypick label: new pull request created: #9916. |
In response to a cherrypick label: new pull request created: #9917. |
What is changed, added or deleted? (Required)
This pull request adds
max-days
andmax-backups
default value 0 means for PD configuration guide. There is a similar document for TiKV'smax-days
andmax-backups
via #7425 There is no PD one.Here are the technical backgrounds for these documentation changes.
https://github.com/tikv/pd/blob/b5e113436c85f81d0e6ca2b5b592271114089db2/conf/config.toml#L97
https://github.com/tikv/pd/blob/b5e113436c85f81d0e6ca2b5b592271114089db2/pkg/logutil/log.go#L33-L34
It says "default is never deleting."
https://github.com/tikv/pd/blob/b5e113436c85f81d0e6ca2b5b592271114089db2/conf/config.toml#L99
https://github.com/tikv/pd/blob/b5e113436c85f81d0e6ca2b5b592271114089db2/pkg/logutil/log.go#L35-L36
log.go
does not anything about the default value. Based on the method lookup, I believe MaxBackups default behavior is defined by https://github.com/natefinch/lumberjack default value as follows.https://github.com/pingcap/log/blob/07caf4f152b9d53fedb241dc5e5aaa282fdaa74b/log.go#L126
https://github.com/natefinch/lumberjack/blob/47ffae23317c5951a2a6267a069cf676edf53eb6/lumberjack.go#L96-L99
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?