Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash refactor: split use-tiflash into multiple docs #9452

Merged
merged 7 commits into from Jul 8, 2022
Merged

tiflash refactor: split use-tiflash into multiple docs #9452

merged 7 commits into from Jul 8, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 1, 2022

What is changed, added or deleted? (Required)

tiflash refactor: split use-tiflash into multiple docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
@TomShawn TomShawn added type/refactor Reorganizes the documentation structure. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. labels Jul 1, 2022
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 1, 2022
@TomShawn TomShawn added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jul 1, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 1, 2022
@TomShawn TomShawn removed the missing-translation-status This PR does not have translation status info. label Jul 1, 2022
TomShawn
TomShawn commented Jul 1, 2022
View reviewed changes
releases/release-6.1.0.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Jul 1, 2022
View reviewed changes
tiflash/tiflash-overview.md Outdated Show resolved Hide resolved
@TomShawn TomShawn requested a review from qiancai July 1, 2022 07:17
@TomShawn TomShawn marked this pull request as ready for review July 1, 2022 07:17
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
TomShawn and others added 2 commits July 1, 2022 16:24
@TomShawn @qiancai
Apply suggestions from code review
11d3bb0 
Co-authored-by: Grace Cai <qqzczy@126.com>
@TomShawn
fix anchor
05d0ac1
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Jul 8, 2022

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor Author

TomShawn commented Jul 8, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2022
@TomShawn TomShawn self-assigned this Jul 8, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Jul 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 05d0ac1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@ti-chi-bot ti-chi-bot merged commit a6bc923 into pingcap:master Jul 8, 2022
@TomShawn TomShawn deleted the tiflash-use=split branch July 8, 2022 02:29
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 8, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#9452
17adae4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9521.

TomShawn added a commit that referenced this pull request Jul 8, 2022
@ti-chi-bot @TomShawn
tiflash refactor: split use-tiflash into multiple docs (#9452) (#9521)
4ac6357 
* This is an automated cherry-pick of #9452

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update tiflash/tiflash-overview.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 8, 2022
@TomShawn TomShawn mentioned this pull request Jul 8, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 11, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@joey-yez joey-yez joey-yez approved these changes

@shichun-0415 shichun-0415 Awaiting requested review from shichun-0415

Assignees

@TomShawn TomShawn

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/refactor Reorganizes the documentation structure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TomShawn @ti-chi-bot @qiancai @joey-yez