Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc for DATA_LOCK_WAITS #9533

Merged
merged 3 commits into from Aug 5, 2022
Merged

Update doc for DATA_LOCK_WAITS #9533

merged 3 commits into from Aug 5, 2022

Conversation

longfangsong
Copy link
Contributor

@longfangsong longfangsong commented Jul 10, 2022 •
edited by TomShawn

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 10, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 10, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 10, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2022
@longfangsong longfangsong mentioned this pull request Jul 10, 2022
Merged
13 tasks
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Jul 11, 2022
@shichun-0415 shichun-0415 requested review from TomShawn and removed request for shichun-0415 July 11, 2022 02:18
@TomShawn TomShawn added type/enhancement This issue/PR improves documentation usability or supplements document content. area/transaction Indicates that the Issue or PR belongs to the area of transaction. labels Jul 11, 2022
@TomShawn
Copy link
Contributor

@longfangsong Could you please sign the CLA agreement as requested by #9533 (comment)? Thanks~

@Oreoxmt Oreoxmt added the v6.2 This PR/issue applies to TiDB v6.2. label Jul 11, 2022
@Oreoxmt Oreoxmt self-requested a review July 11, 2022 02:48
Oreoxmt
Oreoxmt reviewed Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

information-schema/information-schema-data-lock-waits.md Outdated Show resolved Hide resolved
@shichun-0415 shichun-0415 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2022
@Oreoxmt Oreoxmt self-assigned this Jul 21, 2022
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 4, 2022

/verify

@Oreoxmt Oreoxmt added the status/PTAL This PR is ready for reviewing. label Aug 4, 2022
@Oreoxmt @TomShawn
Apply suggestions from code review
c239ff4 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Oreoxmt
Oreoxmt approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2022
@Oreoxmt Oreoxmt requested a review from TomShawn August 4, 2022 11:03
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2022
@Oreoxmt Oreoxmt removed the status/PTAL This PR is ready for reviewing. label Aug 5, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c239ff4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@ti-chi-bot ti-chi-bot merged commit 4ba536e into pingcap:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/transaction Indicates that the Issue or PR belongs to the area of transaction. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@longfangsong @ti-chi-bot @CLAassistant @TomShawn @Oreoxmt @shichun-0415