New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv-control: make a parameter in right places #9549
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tikv-control.md
Outdated
@@ -229,6 +229,7 @@ Use the `compact` command to manually compact data of each TiKV. If you specify | |||
|
|||
- Use the `--host` option to specify the TiKV that needs to perform compaction. | |||
- Use the `-d` option to specify the RocksDB that performs compaction. The optional values are `kv` and `raft`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a670d19
/verify |
tikv-control.md
Outdated
@@ -228,7 +228,7 @@ The properties can be used to check whether the Region is healthy or not. If not | |||
Use the `compact` command to manually compact data of each TiKV. If you specify the `--from` and `--to` options, then their flags are also in the form of escaped raw key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refresh the whole description, please update
Compact data of each TiKV manually
Use the compact
command to manually compact data of each TiKV.
-
Use the
--from
and--to
options to sepecify the compact range in the form of escaped raw key. If not set, the whole range will be compacted. -
Use the
--region
option to compact range of a specific region. If set,--from
and--to
will be ignored. -
Use the
--db
option to specify the RocksDB that performs compaction. The optional values arekv
andraft
. -
Use the
--threads
option allows you to specify the concurrency for the TiKV compaction and its default value is8
. Generally, a higher concurrency comes with a faster compaction speed, which might yet affect the service. You need to choose an appropriate concurrency count based on your scenario. -
Use the
--bottommost
option to include or exclude the bottommost files when TiKV performs compaction. The value options aredefault
,skip
, andforce
. The default value isdefault
.default
means that the bottommost files are included only when the Compaction Filter feature is enabled.skip
means that the bottommost files are excluded when TiKV performs compaction.force
means that the bottommost files are always included when TiKV performs compaction.
-
For local mode
{{< copyable "shell-regular" >}}
$ tikv-ctl --data-dir /path/to/tikv compact --db kv
success!
- For remote mode
{{< copyable "shell-regular" >}}
$ tikv-ctl --host ip:port compact --db kv
success!
@Connor1996 @hicqu PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/status LGT1 |
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 986bd14
|
In response to a cherrypick label: new pull request created: #10771. |
In response to a cherrypick label: new pull request created: #10772. |
In response to a cherrypick label: new pull request created: #10773. |
In response to a cherrypick label: new pull request created: #10774. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?