Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: fix incorrect relationship between x86_64 and arm #9561

Merged
merged 1 commit into from Jul 14, 2022
Merged

tiup: fix incorrect relationship between x86_64 and arm #9561

merged 1 commit into from Jul 14, 2022

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. ONCALL Relates to documentation oncall. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2022
@shichun-0415
Copy link
Contributor Author

/verify

@shichun-0415 shichun-0415 requested review from srstack, TomShawn and Oreoxmt and removed request for TomShawn July 14, 2022 04:37
Oreoxmt
Oreoxmt approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022
@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 14, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 59d1fe9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022
@shichun-0415 shichun-0415 merged commit e02e1c7 into pingcap:master Jul 14, 2022
@shichun-0415 shichun-0415 deleted the fix-x86_64-and-arm branch July 14, 2022 08:26
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9567.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9568.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 14, 2022
@shichun-0415 @ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (pingcap#9561)
037895b
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9569.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9570.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9571.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9572.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9573.

ti-chi-bot added a commit that referenced this pull request Jul 14, 2022
@ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (#9561) (#9567)
486129b
ti-chi-bot added a commit that referenced this pull request Jul 14, 2022
@ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (#9561) (#9568)
bd700f4
ti-chi-bot added a commit that referenced this pull request Jul 14, 2022
@ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (#9561) (#9573)
a874f7b
ti-chi-bot added a commit that referenced this pull request Jul 14, 2022
@ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (#9561) (#9569)
d5578cc
ti-chi-bot added a commit that referenced this pull request Jul 14, 2022
@ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (#9561) (#9572)
c6f0569
ti-chi-bot added a commit that referenced this pull request Jul 14, 2022
@ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (#9561) (#9571)
90b328d
ti-chi-bot added a commit that referenced this pull request Jul 14, 2022
@ti-chi-bot
tiup: fix incorrect relationship between x86_64 and arm (#9561) (#9570)
a2553ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqqdan qqqdan qqqdan approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@srstack srstack Awaiting requested review from srstack

Assignees
No one assigned
Labels
area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shichun-0415 @ti-chi-bot @qqqdan @Oreoxmt