Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add content for clinic us server #9566

Merged
merged 8 commits into from Jul 15, 2022
Merged

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jul 14, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/clinic This PR relates to the area of TiDB Clinic. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jul 14, 2022
@Oreoxmt Oreoxmt requested review from qqqdan and TomShawn July 14, 2022 08:09
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 14, 2022
Oreoxmt and others added 3 commits July 14, 2022 17:16
Co-authored-by: qqqdan <qiaodan@pingcap.com>
Co-authored-by: qqqdan <qiaodan@pingcap.com>
Co-authored-by: qqqdan <qiaodan@pingcap.com>
clinic/clinic-data-instruction-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-data-instruction-for-tiup.md Outdated Show resolved Hide resolved
clinic/clinic-introduction.md Outdated Show resolved Hide resolved
clinic/clinic-introduction.md Outdated Show resolved Hide resolved
clinic/clinic-introduction.md Outdated Show resolved Hide resolved
clinic/quick-start-with-clinic.md Outdated Show resolved Hide resolved
clinic/quick-start-with-clinic.md Outdated Show resolved Hide resolved
clinic/quick-start-with-clinic.md Outdated Show resolved Hide resolved
clinic/quick-start-with-clinic.md Outdated Show resolved Hide resolved
clinic/quick-start-with-clinic.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested review from shichun-0415 and qqqdan and removed request for TomShawn July 15, 2022 03:00
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

<SimpleTab>
<div label="Clinic Server in the US">

Go to the [Clinic Server in the US](https://clinic.pingcap.com) and select **Sign in with TiDB Account** to enter the TiDB Cloud login page. If you do not have an TiDB Cloud account, create one on that page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Go to the [Clinic Server in the US](https://clinic.pingcap.com) and select **Sign in with TiDB Account** to enter the TiDB Cloud login page. If you do not have an TiDB Cloud account, create one on that page.
Go to the [Clinic Server in the US](https://clinic.pingcap.com) and select **Sign in with TiDB Account** to enter the TiDB Cloud login page. If you do not have a TiDB Cloud account, create one on that page.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 15, 2022

/remove-label LGT1
/status LGT2

@ti-chi-bot
Copy link
Member

@Oreoxmt: The label(s) lgt1 cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v5.1, v5.2, v5.3, v5.4, v6.0, v6.1, v6.2, for-future-release, requires-version-specific-changes, website.

In response to this:

/remove-label LGT1
/status LGT2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 15, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e7622a3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@ti-chi-bot ti-chi-bot merged commit 6182937 into pingcap:master Jul 15, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9577.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9578.

@Oreoxmt Oreoxmt deleted the translate/10362 branch July 25, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clinic This PR relates to the area of TiDB Clinic. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants