Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb lightning: fix old download location for lightning.json #9586

Merged
merged 1 commit into from Jul 18, 2022
Merged

tidb lightning: fix old download location for lightning.json #9586

merged 1 commit into from Jul 18, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Jul 15, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Close #9585

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dveeden
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2022
@shichun-0415 shichun-0415 added type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. ONCALL Relates to documentation oncall. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 15, 2022
@shichun-0415 shichun-0415 requested review from ran-huang, sunzhaoyang and dveeden and removed request for sunzhaoyang July 15, 2022 12:54
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ee5fdc3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@shichun-0415 shichun-0415 merged commit 9612712 into pingcap:master Jul 18, 2022
@shichun-0415 shichun-0415 deleted the fix-ansible-in-lightning branch July 18, 2022 06:34
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9598.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9599.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9600.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9601.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9602.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9603.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9604.

ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600)
b7682dc
This was referenced Jul 18, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600) (#…
48f4d8f 
…9605)
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600) (#…
57b36b7 
…9606)
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600) (#…
7ccaa5d 
…9610)
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600) (#…
3d1e752 
…9608)
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600) (#…
4fc37be 
…9607)
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600) (#…
747853d 
…9611)
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
tidb lightning: remove description about json file (#9586) (#9600) (#…
d72513f 
…9609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dveeden dveeden dveeden approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old download location for lightning.json
4 participants
@shichun-0415 @ti-chi-bot @dveeden @ran-huang