Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.2: add doc for auto analyze auto tune support #9630

Merged
merged 6 commits into from Aug 5, 2022
Merged

v6.2: add doc for auto analyze auto tune support #9630

merged 6 commits into from Aug 5, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 19, 2022 •
edited

What is changed, added or deleted? (Required)

v6.2: add doc for auto analyze auto tune support

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2022
@TomShawn TomShawn requested review from Oreoxmt and BornChanger and removed request for shichun-0415 July 19, 2022 08:14
@TomShawn TomShawn added area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. v6.2 This PR/issue applies to TiDB v6.2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Jul 19, 2022
@shichun-0415 shichun-0415 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 20, 2022
Oreoxmt
Oreoxmt approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2022
@TomShawn TomShawn closed this Aug 5, 2022
@TomShawn TomShawn reopened this Aug 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/cherry-pick master-0727

@ti-chi-bot
Copy link
Member

@TomShawn: once the present PR merges, I will cherry-pick it on top of master-0727 in the new PR and assign it to you.

In response to this:

/cherry-pick master-0727

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/rebase

@TomShawn TomShawn force-pushed the auto-analyze-auto-tune-support-6.2 branch from d8c7cf5 to 594a8da Compare August 5, 2022 05:59
BornChanger
BornChanger reviewed Aug 5, 2022
View reviewed changes
sql-statements/sql-statement-show-config.md
> **Warning:**
>
> This feature is currently an experimental feature. It is not recommended to use this feature in the production environment.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的改动和 quota limiter GA 无关吧, 为什么会有这个?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

顺便改的，和 feature 无关，可以忽略

tikv-configuration-file.md Outdated

+ The soft limit on the bandwidth with which transactions write data.
+ Default value: `0KB` (which means no limit)
+ Recommended setting: Use the default value `0` in most cases unless the `foreground-cpu-time` setting is not enough to limit the write bandwidth. For such an exception, it is recommended to set the value smaller than 50M in the instance with 4 or less cores.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把 50M 改成 50MB 更准确

tikv-configuration-file.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Aug 5, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn @Oreoxmt
Apply suggestions from code review
e3a4ddc 
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e3a4ddc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@ti-chi-bot ti-chi-bot merged commit 0872873 into pingcap:master Aug 5, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 5, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

@TomShawn: new pull request created: #9856.

In response to this:

/cherry-pick master-0727

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn deleted the auto-analyze-auto-tune-support-6.2 branch August 5, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@BornChanger BornChanger BornChanger left review comments

Assignees
No one assigned
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TomShawn @ti-chi-bot @Oreoxmt @BornChanger @shichun-0415