tikv: update the Load Base Split introduction #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oreoxmt
added
translation/from-docs-cn
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
size/S
Oreoxmt
removed
the
do-not-merge/hold
JmPotato
reviewed
Jul 21, 2022
configure-load-base-split.md
Outdated
| - `split.byte-threshold`: The threshold of read load for the Region to be split, default is 30 MiB per second. | ||
| - `split.region-cpu-overload-threshold-ratio`: The threshold of CPU usage (the percentage of CPU time of the read thread pool) for the Region to be split, default is `0.25`. | ||
|
|
||
| If the sum of all types of read requests per second for a Region exceeds the QPS threshold or traffic threshold for 10 consecutive seconds, PD splits the Region. |
There was a problem hiding this comment.
What about the CPU usage threshold?
There was a problem hiding this comment.
Also, it's not that "PD splits the Region", this is a TiKV feature that doesn't involve PD, so the precise description should be like "TiKV tries to split the Region".
dynamic-config.md
Outdated
| @@ -207,6 +207,7 @@ The following TiKV configuration items can be modified online: | |||
| | `backup.num-threads` | The number of backup threads (supported since v4.0.3) | | |||
| | `split.qps-threshold` | The threshold to execute `load-base-split` on a Region. If the QPS of read requests for a Region exceeds `qps-threshold` for a consecutive period of time, this Region should be split.| | |||
| | `split.byte-threshold` | The threshold to execute `load-base-split` on a Region. If the traffic of read requests for a Region exceeds the `byte-threshold` for a consecutive period of time, this Region should be split. | | |||
| | `split.region-cpu-overload-threshold-ratio` | The threshold to execute `load-base-split` on a Region. If the CPU usage of unified read pool for a Region exceeds the `region-cpu-overload-threshold-ratio` for a consecutive period of time, this Region should be split. (supported since v6.2.0) | | |||
There was a problem hiding this comment.
Unified Read Pool is a TiKV-specific concept, so I think it should be capitalized.
Suggested change
| | `split.region-cpu-overload-threshold-ratio` | The threshold to execute `load-base-split` on a Region. If the CPU usage of unified read pool for a Region exceeds the `region-cpu-overload-threshold-ratio` for a consecutive period of time, this Region should be split. (supported since v6.2.0) | | |
| | `split.region-cpu-overload-threshold-ratio` | The threshold to execute `load-base-split` on a Region. If the CPU usage of Unified Read Pool for a Region exceeds the `region-cpu-overload-threshold-ratio` for a consecutive period of time, this Region should be split. (supported since v6.2.0) | |
Co-authored-by: JmPotato <github@ipotato.me>
JmPotato
approved these changes
Jul 25, 2022
|
/status LGT1 |
TomShawn
reviewed
Aug 4, 2022
configure-load-base-split.md
Outdated
|
|
||
| The Region split by Load Base Split will not be merged quickly. On the one hand, PD's `MergeChecker` skips the hot Regions; on the other hand, PD also determines whether to merge two Regions according to `QPS` in the heartbeat information, to avoid the merging of two Regions with high `QPS`. | ||
|
|
||
| ## Usage | ||
|
|
||
| The Load Base Split feature is currently controlled by the `split.qps-threshold` parameter (QPS threshold) and `split.byte-threshold` parameter (traffic threshold). If the sum of all types of read requests per second for a Region exceeds the QPS threshold or traffic threshold for 10 consecutive seconds, PD splits the Region. | ||
| The Load Base Split feature is currently controlled by three parameters: |
There was a problem hiding this comment.
Suggested change
| The Load Base Split feature is currently controlled by three parameters: | |
| The Load Base Split feature is currently controlled by the following parameters: |
configure-load-base-split.md
Outdated
|
|
||
| Load Base Split is enabled by default, but the parameter is set to a rather high value. `split.qps-threshold` defaults to `3000` and `split.byte-threshold` defaults to 30MB/s. If you want to disable this feature, set the two thresholds high enough at the same time. | ||
| - `split.qps-threshold`: The threshold of QPS for the Region to be split, default is `3000` per second. |
There was a problem hiding this comment.
Suggested change
| - `split.qps-threshold`: The threshold of QPS for the Region to be split, default is `3000` per second. | |
| - `split.qps-threshold`: The QPS threshold at which a Region is identified as a hotspot. The default value is `3000` per second. |
configure-load-base-split.md
Outdated
|
|
||
| Load Base Split is enabled by default, but the parameter is set to a rather high value. `split.qps-threshold` defaults to `3000` and `split.byte-threshold` defaults to 30MB/s. If you want to disable this feature, set the two thresholds high enough at the same time. | ||
| - `split.qps-threshold`: The threshold of QPS for the Region to be split, default is `3000` per second. | ||
| - `split.byte-threshold`: The threshold of read load for the Region to be split, default is 30 MiB per second. |
There was a problem hiding this comment.
Suggested change
| - `split.byte-threshold`: The threshold of read load for the Region to be split, default is 30 MiB per second. | |
| - `split.byte-threshold`: The traffic threshold at which a Region is identified as a hotspot. The default value is 30 MiB per second. |
configure-load-base-split.md
Outdated
| Load Base Split is enabled by default, but the parameter is set to a rather high value. `split.qps-threshold` defaults to `3000` and `split.byte-threshold` defaults to 30MB/s. If you want to disable this feature, set the two thresholds high enough at the same time. | ||
| - `split.qps-threshold`: The threshold of QPS for the Region to be split, default is `3000` per second. | ||
| - `split.byte-threshold`: The threshold of read load for the Region to be split, default is 30 MiB per second. | ||
| - `split.region-cpu-overload-threshold-ratio`: The threshold of CPU usage (the percentage of CPU time of the read thread pool) for the Region to be split, default is `0.25`. |
There was a problem hiding this comment.
English and Chinese are inconsistent. Please check and update.
configure-load-base-split.md
Outdated
| - `split.byte-threshold`: The threshold of read load for the Region to be split, default is 30 MiB per second. | ||
| - `split.region-cpu-overload-threshold-ratio`: The threshold of CPU usage (the percentage of CPU time of the read thread pool) for the Region to be split, default is `0.25`. | ||
|
|
||
| If the sum of all types of read requests per second for a Region exceeds the QPS threshold, traffic threshold, or CPU usage threshold for 10 consecutive seconds, TiKV tries to split the Region. |
There was a problem hiding this comment.
Suggested change
| If the sum of all types of read requests per second for a Region exceeds the QPS threshold, traffic threshold, or CPU usage threshold for 10 consecutive seconds, TiKV tries to split the Region. | |
| If a Region meets one of the following conditions for 10 consecutive seconds, TiKV tries to split the Region: | |
| - the sum of its read requests exceeds `split.qps-threshold`. | |
| - its traffic exceeds `split.byte-threshold`. | |
| - its CPU usage in the Unified Read Pool exceeds `split.region-cpu-overload-threshold-ratio`. |
TomShawn
reviewed
Aug 4, 2022
dynamic-config.md
Outdated
| @@ -207,6 +207,7 @@ The following TiKV configuration items can be modified online: | |||
| | `backup.num-threads` | The number of backup threads (supported since v4.0.3) | | |||
| | `split.qps-threshold` | The threshold to execute `load-base-split` on a Region. If the QPS of read requests for a Region exceeds `qps-threshold` for a consecutive period of time, this Region should be split.| | |||
| | `split.byte-threshold` | The threshold to execute `load-base-split` on a Region. If the traffic of read requests for a Region exceeds the `byte-threshold` for a consecutive period of time, this Region should be split. | | |||
| | `split.region-cpu-overload-threshold-ratio` | The threshold to execute `load-base-split` on a Region. If the CPU usage in the Unified Read Pool for a Region exceeds the `region-cpu-overload-threshold-ratio` for a consecutive period of time, this Region should be split. (supported since v6.2.0) | | |||
There was a problem hiding this comment.
Does "for a consecutive period of time" mean 10 seconds?
There was a problem hiding this comment.
Does "for a consecutive period of time" mean 10 seconds?
Yes, fixed in 46fa37c
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 46fa37c
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Update the description of load base split:
split.region-cpu-overload-threshold-ratioWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?