Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

betwwen → between #9664

Merged
merged 2 commits into from Jul 21, 2022
Merged

betwwen → between #9664

merged 2 commits into from Jul 21, 2022

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 20, 2022 •
edited

What is changed, added or deleted? (Required)

"betwwen" → "between"

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 20, 2022
@dveeden
Copy link
Contributor Author

dveeden commented Jul 20, 2022

Please check if the alias is setup correctly

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 20, 2022
@dveeden
Copy link
Contributor Author

dveeden commented Jul 20, 2022

Wasn't sure which branches to target

@dveeden dveeden requested a review from qiancai July 20, 2022 11:22
@shichun-0415
Copy link
Contributor

Wasn't sure which branches to target

I'll cherry pick this PR to branches v6.0 and v6.1 because this doc is added to v6.0 and later versions.

@shichun-0415 shichun-0415 added type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. translation/no-need No need to translate this PR. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. and removed missing-translation-status This PR does not have translation status info. labels Jul 20, 2022
@dveeden @shichun-0415
Update replicate-between-primary-and-secondary-clusters.md
325ca5e 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
shichun-0415
shichun-0415 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 21, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 325ca5e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@ti-chi-bot ti-chi-bot merged commit 9743d42 into pingcap:master Jul 21, 2022
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jul 22, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9682.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 22, 2022
@dveeden @ti-chi-bot
This is an automated cherry-pick of pingcap#9664
ade44f8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 22, 2022
Merged
12 tasks
ti-chi-bot added a commit that referenced this pull request Jul 22, 2022
@ti-chi-bot
betwwen → between (#9664) (#9682)
d560257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@qiancai qiancai Awaiting requested review from qiancai

Assignees
No one assigned
Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dveeden @ti-chi-bot @shichun-0415 @ran-huang