Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: add command line flag --config-info #9777

Merged
merged 2 commits into from Aug 5, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Aug 1, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add the description of --config-info, which lists available configuration values.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. v6.2 This PR/issue applies to TiDB v6.2. labels Aug 1, 2022
@Oreoxmt Oreoxmt requested review from glorv and TomShawn August 1, 2022 05:11
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 1, 2022

/verify

1 similar comment
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 1, 2022

/verify

@Oreoxmt Oreoxmt self-assigned this Aug 2, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 2, 2022

/verify

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

command-line-flags-for-tikv-configuration.md Outdated Show resolved Hide resolved
command-line-flags-for-tikv-configuration.md Outdated Show resolved Hide resolved
command-line-flags-for-tikv-configuration.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2022
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 5, 2022

/remove-status LGT1
/status LGT2
/merge

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5b9e43e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@ti-chi-bot ti-chi-bot merged commit 1733797 into pingcap:master Aug 5, 2022
@Oreoxmt Oreoxmt deleted the translate/docs-cn-10615 branch February 14, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants